fix clean up registration of blocks #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's awesome, thanks Fabian! 👏 Just FYI - we have on the roadmap the ability to automatically detect if a block is using directives: WordPress/block-interactivity-experiments#126. This can be done using the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current iteration there are a few manual steps that need to be done in order for an interactive block to work correctly that are not how these blocks will work in the future. This PR updates the flow so that all these steps get handled automatically by the plugin instead of manually by the block author.
This PR updates it so that any block that has
supports.interactivityset to true will automatically get thewp-directive-runtimescript dependency added to anyviewScriptscripts.Additionally it also auto registers all the blocks. So when you add a new block you don't need to touch any files outside of the blocks folder itself.